nu/CharmBoard
1
0
Fork 0
Code Issues 8 Pull requests Projects 1 Releases Activity

Stop using smartmatch ~~ #15

New issue
Closed
opened 2024-08-19 08:07:28 +00:00 by nu · 3 comments
nu commented 2024-08-19 08:07:28 +00:00
Owner
Copy link

I don't think it does what I thought it did back when I started using it, so it'd be better to just... Not.

I don't think it does what I thought it did back when I started using it, so it'd be better to just... Not.
nu added this to the CharmBoard v1.0 milestone 2024-08-19 08:07:28 +00:00
nu commented 2024-08-19 08:07:34 +00:00
Author
Owner
Copy link

For, i.e. the database type checker, it might be better to force lowercase the config value before comparing it, so if someone types SQLite in the config instead of sqlite then it doesn't die unnecessarily. I believe this is what I intended when deciding to use smartmatch here.

For, i.e. the database type checker, it might be better to force lowercase the config value before comparing it, so if someone types `SQLite` in the config instead of `sqlite` then it doesn't die unnecessarily. I believe this is what I intended when deciding to use smartmatch here.
nu commented 2024-08-19 08:08:24 +00:00
Author
Owner
Copy link

For, i.e. the database type checker, it might be better to force lowercase the config value before comparing it, so if someone types SQLite in the config instead of sqlite then it doesn't die unnecessarily. I believe this is what I intended when deciding to use smartmatch here.

For, i.e. the database type checker, it might be better to force lowercase the config value before comparing it, so if someone types `SQLite` in the config instead of `sqlite` then it doesn't die unnecessarily. I believe this is what I intended when deciding to use smartmatch here.
nu commented 2024-08-19 08:11:24 +00:00
Author
Owner
Copy link

Yeah... That's literally the only place I was using smartmatch. Now to go through and change each use experimental qw(try smartmatch); line to just use experimental qw(try); in every. single. PM file.

Yeah... That's literally the only place I was using smartmatch. Now to go through and change each `use experimental qw(try smartmatch);` line to just `use experimental qw(try);` in every. single. PM file.
nu closed this issue 2024-08-19 08:14:28 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
bug

   
code clarity

   
code organization

   
database

   
documentation

   
improvement

   
new feature

   
security
No labels
bug
code clarity
code organization
database
documentation
improvement
new feature
security
Milestone
Clear milestone
No items
No milestone
CharmBoard v1.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nu/CharmBoard#15
No description provided.